packages/lib/server/repository/membership.ts (1)

480-507: Clarify inclusion of unaccepted memberships and tighten types (optional)

This returns all memberships unless filters.accepted is provided. If call sites use this for auth scoping, you likely want accepted: true by default to avoid pulling pending invites.

If intentional, ignore. Otherwise, consider defaulting accepted to true at the caller or here.

Optionally, expose a typed return DTO to avoid accidental shape drift in consumers.

packages/features/calAIPhone/providers/retellAI/RetellAIService.ts (1)

246-254: Avoid any for filters; align with input schema

Use a precise type for filters to prevent accidental shape drift between TRPC input, services, and repository.

Apply this diff:

-  async listCalls(params: {
-    userId: number;
-    organizationId?: number;
-    limit?: number;
-    offset?: number;
-    filters?: any;
-  }) {
+  async listCalls(params: {
+    userId: number;
+    organizationId?: number;
+    limit?: number;
+    offset?: number;
+    filters?: { phoneNumberId?: string[]; startDate?: string; endDate?: string };
+  }) {
     return this.callService.listCalls(params);
   }

packages/features/calAIPhone/providers/retellAI/RetellAIPhoneServiceProvider.ts (1)

294-302: Type filters and confirm org-level scope

Mirror the filter shape here to keep provider surface strongly typed. Also confirm that organizationId (not teamId) is the intended scope for listing calls.

Apply this diff:

-  async listCalls(params: {
-    userId: number;
-    organizationId?: number;
-    limit?: number;
-    offset?: number;
-    filters?: any;
-  }) {
+  async listCalls(params: {
+    userId: number;
+    organizationId?: number;
+    limit?: number;
+    offset?: number;
+    filters?: { phoneNumberId?: string[]; startDate?: string; endDate?: string };
+  }) {
     return await this.service.listCalls(params);
   }

packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.schema.ts (1)

1-15: Strengthen date validation and enforce start ≤ end (optional)

Tighten filters to catch malformed dates and inverted ranges at the boundary.

Apply this diff:

 export const ZListCallsInputSchema = z.object({
   limit: z.number().min(1).max(1000).default(50),
   offset: z.number().min(0).default(0),
   filters: z
     .object({
       phoneNumberId: z.array(z.string()).optional(),
-      startDate: z.string().optional(),
-      endDate: z.string().optional(),
+      startDate: z.string().datetime().optional(),
+      endDate: z.string().datetime().optional(),
     })
+    .refine(
+      (f) => !f?.startDate || !f?.endDate || new Date(f.startDate) <= new Date(f.endDate),
+      { message: "endDate must be on or after startDate" }
+    )
     .optional(),
 });

packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.handler.ts (1)

67-74: Honor phone number filter from input.

filters.phoneNumberId exists in schema but isn’t applied. If intended to filter by specific numbers, apply it here; otherwise remove from schema to avoid dead params.

Apply:

-    const calls = await aiService.listCalls({
-      phoneNumbers: uniquePhoneNumbers,
+    const scopedPhoneNumbers =
+      input.filters?.phoneNumberId?.length
+        ? uniquePhoneNumbers.filter((pn) => input.filters!.phoneNumberId!.includes(pn))
+        : uniquePhoneNumbers;
+
+    const calls = await aiService.listCalls({
+      phoneNumbers: scopedPhoneNumbers,
       limit: input.limit,
       offset: input.offset,
       filters: {
         ...(startTimestamp && { startTimestamp }),
       },
     });

If phoneNumberId truly refers to DB IDs, map IDs → numbers via repository before filtering.

apps/web/app/(use-page-wrapper)/insights/call-history/page.tsx (1)

7-14: Remove redundant await in generateMetadata.

No need to await and then return; just return the promise.

-export const generateMetadata = async () =>
-  await _generateMetadata(
+export const generateMetadata = () =>
+  _generateMetadata(
     (t) => t("call_history"),
     (t) => t("call_history_subtitle"),
     undefined,
     undefined,
     "/insights/call-history"
   );

apps/web/modules/insights/insights-call-history-view.tsx (4)

16-16: Remove unused branding plumbing.

useOrgBranding() and _domain are unused; drop both to reduce noise.

-import { useOrgBranding } from "@calcom/features/ee/organizations/context/provider";
@@
-function CallHistoryContent({ org: _org }: CallHistoryProps) {
-  const orgBranding = useOrgBranding();
-  const _domain = orgBranding?.fullDomain ?? WEBAPP_URL;
+function CallHistoryContent({ org: _org }: CallHistoryProps) {

Also applies to: 73-75

---

116-132: Handle missing timestamps in renderer.

Avoid creating Date("") or showing current time when data is absent.

-          const date = new Date(row.original.time);
-          return (
+          const hasTime = Boolean(row.original.time);
+          return hasTime ? (
+            (() => {
+              const date = new Date(row.original.time);
+              return (
+                <div className="text-sm">
+                  <div>{date.toLocaleDateString()}</div>
+                  <div className="text-subtle">{date.toLocaleTimeString()}</div>
+                </div>
+              );
+            })()
+          ) : (
             <div className="text-sm">
-              <div>{date.toLocaleDateString()}</div>
-              <div className="text-subtle">{date.toLocaleTimeString()}</div>
+              <div>{t("unknown")}</div>
             </div>
           );

---

169-181: Status mapping: add fallback instead of coercing to "failed".

Unknown provider statuses shouldn’t be labeled failed.

-          const status = row.original.sessionStatus;
+          const status = row.original.sessionStatus ?? "unknown";
-          const variant = status === "completed" ? "green" : status === "ongoing" ? "blue" : "red";
-          return <Badge variant={variant}>{status}</Badge>;
+          const variant = status === "completed" ? "green" : status === "ongoing" ? "blue" : status === "failed" ? "red" : "gray";
+          return <Badge variant={variant}>{status}</Badge>;

And in the mapping above:

-      sessionStatus:
-        call.call_status === "ended" ? "completed" : call.call_status === "ongoing" ? "ongoing" : "failed",
+      sessionStatus:
+        call.call_status === "ended"
+          ? "completed"
+          : call.call_status === "ongoing"
+            ? "ongoing"
+            : undefined,

---

251-273: Localize facet labels.

Hardcoded English breaks i18n. Use t() for labels.

-            { label: "Web Call", value: "web_call" },
-            { label: "Phone Call", value: "phone_call" },
+            { label: t("web_call"), value: "web_call" },
+            { label: t("phone_call"), value: "phone_call" },
@@
-            { label: "Completed", value: "completed" },
-            { label: "Ongoing", value: "ongoing" },
-            { label: "Failed", value: "failed" },
+            { label: t("completed"), value: "completed" },
+            { label: t("ongoing"), value: "ongoing" },
+            { label: t("failed"), value: "failed" },
@@
-            { label: "Positive", value: "positive" },
-            { label: "Neutral", value: "neutral" },
-            { label: "Negative", value: "negative" },
+            { label: t("positive"), value: "positive" },
+            { label: t("neutral"), value: "neutral" },
+            { label: t("negative"), value: "negative" },

packages/features/ee/workflows/components/CallDetailsSheet.tsx (2)

95-96: Localize "Unknown".

Avoid hardcoded English; use t("unknown") or similar.

-                  {selectedCall.call_analysis?.user_sentiment || "Unknown"}
+                  {selectedCall.call_analysis?.user_sentiment || t("unknown")}

---

115-126: Guard recording section and localize audio fallback.

Render recording only when a URL exists and localize the fallback text.

-          {/* Recording Section */}
-          <div className="space-y-3">
+          {/* Recording Section */}
+          {selectedCall.recording_url && (
+          <div className="space-y-3">
             <h3 className="text-emphasis text-base font-semibold">{t("recording")}</h3>
             <div className="flex items-center gap-3">
-              <audio controls className="h-11 w-[258px]" src={selectedCall.recording_url}>
-                Your browser does not support the audio element.
+              <audio controls className="h-11 w-[258px]" src={selectedCall.recording_url}>
+                {t("audio_not_supported")}
               </audio>
               <Button color="minimal" href={selectedCall.recording_url} target="_blank" StartIcon="download">
                 {t("download")}
               </Button>
             </div>
           </div>
+          )}

packages/lib/server/repository/calAiPhoneNumber.ts (1)

28-55: Dedup at the DB level and add explicit return types.

Small perf/readability wins:

• Use Prisma distinct: ["phoneNumber"] in each finder to reduce duplicates early.
• Add explicit return types for the helper methods.

 export class CalAiPhoneNumberRepository {
-  static async getUserPhoneNumbers(userId: number) {
+  static async getUserPhoneNumbers(
+    userId: number
+  ): Promise<Array<{ phoneNumber: string }>> {
     return prisma.calAiPhoneNumber.findMany({
       where: { userId },
       select: { phoneNumber: true },
+      distinct: ["phoneNumber"],
     });
   }
 
-  static async getOrganizationTeamPhoneNumbers(organizationId: number) {
+  static async getOrganizationTeamPhoneNumbers(
+    organizationId: number
+  ): Promise<Array<{ phoneNumber: string }>> {
     return prisma.calAiPhoneNumber.findMany({
       where: {
         team: { parentId: organizationId },
       },
       select: { phoneNumber: true },
+      distinct: ["phoneNumber"],
     });
   }
 
-  static async getTeamPhoneNumbers(teamIds: number[]) {
+  static async getTeamPhoneNumbers(
+    teamIds: number[]
+  ): Promise<Array<{ phoneNumber: string }>> {
     return prisma.calAiPhoneNumber.findMany({
       where: { teamId: { in: teamIds } },
       select: { phoneNumber: true },
+      distinct: ["phoneNumber"],
     });
   }

packages/features/ee/workflows/pages/call-history.tsx (8)

150-158: Localize channel type cell text.

Replace raw strings with t().

-        cell: ({ row }) => <span>{row.original.channelType}</span>,
+        cell: ({ row }) => (
+          <span>
+            {row.original.channelType === "web_call" ? t("web_call") : t("phone_call")}
+          </span>
+        ),

---

173-185: Localize session status badge text.

Use t() for user-visible strings.

-          return <Badge variant={variant}>{status}</Badge>;
+          return (
+            <Badge variant={variant}>
+              {status === "completed" ? t("completed") : status === "ongoing" ? t("ongoing") : t("failed")}
+            </Badge>
+          );

---

187-199: Localize sentiment badge text.

Replace with t().

-          return <Badge variant={variant}>{sentiment}</Badge>;
+          return (
+            <Badge variant={variant}>
+              {sentiment === "positive" ? t("positive") : sentiment === "negative" ? t("negative") : t("neutral")}
+            </Badge>
+          );

---

255-277: Localize facet filter labels.

These should use t() to match the rest of the UI.

         case "channelType":
           return convertFacetedValuesToMap([
-            { label: "Web Call", value: "web_call" },
-            { label: "Phone Call", value: "phone_call" },
+            { label: t("web_call"), value: "web_call" },
+            { label: t("phone_call"), value: "phone_call" },
           ]);
         case "sessionStatus":
           return convertFacetedValuesToMap([
-            { label: "Completed", value: "completed" },
-            { label: "Ongoing", value: "ongoing" },
-            { label: "Failed", value: "failed" },
+            { label: t("completed"), value: "completed" },
+            { label: t("ongoing"), value: "ongoing" },
+            { label: t("failed"), value: "failed" },
           ]);
         case "userSentiment":
           return convertFacetedValuesToMap([
-            { label: "Positive", value: "positive" },
-            { label: "Neutral", value: "neutral" },
-            { label: "Negative", value: "negative" },
+            { label: t("positive"), value: "positive" },
+            { label: t("neutral"), value: "neutral" },
+            { label: t("negative"), value: "negative" },
           ]);

---

74-83: Remove unused locals or document intentional side-effects.

• _domain is unused.
• _columnFilters and _searchTerm look intentionally unused for provider side-effects; add a short comment, or wire them to the query (see next comment).

-  const orgBranding = useOrgBranding();
-  const _domain = orgBranding?.fullDomain ?? WEBAPP_URL;
+  const orgBranding = useOrgBranding(); // branding may be used later; keep hook order
+  // const _domain = orgBranding?.fullDomain ?? WEBAPP_URL; // unused

---

238-255: Drop rowSelection plumbing since selection is disabled.

Simplify: remove local rowSelection state and related props.

-  const [rowSelection, setRowSelection] = useState({});
...
   const table = useReactTable({
     data: callHistoryData,
     columns,
     enableRowSelection: false,
     manualPagination: true,
-    state: {
-      rowSelection,
-    },
+    state: {},
...
-    onRowSelectionChange: setRowSelection,
-    getRowId: (row) => row.id,
+    getRowId: (row) => row.id,

Also applies to: 78-79

---

201-211: Use a matching translation key for the "to" header

en/common.json defines "to" (line 1728) while the "from" column uses "from_header" (line 2477). In packages/features/ee/workflows/pages/call-history.tsx (lines 201–211) either change t("to") → t("to_header") and add "to_header": "To" to the locales file, or keep t("to") to match the existing key — preferred: add "to_header" and use it.

---

84-94: Wire supported table filters to listCalls (schema supports phoneNumberId, startDate, endDate — not searchTerm/sorting)

• Update packages/features/ee/workflows/pages/call-history.tsx (lines 84–94) to pass the table’s filter values into trpc.viewer.aiVoiceAgent.listCalls (use filters: { phoneNumberId, startDate, endDate }) instead of filters: {}.
• If you need searchTerm or sorting, first extend ZListCallsInputSchema and listCalls.handler (and propagate to aiService.listCalls) to accept and implement those fields.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/ai/_router.ts:46-84
Timestamp: 2025-08-14T10:48:52.586Z
Learning: In calcom/cal.com PR #22995, packages/trpc/server/routers/viewer/ai/_router.ts, the voiceId input parameter in the create endpoint is intentionally not forwarded to aiService.createAgent() as voice customization is not required at the moment (per maintainer Udit-takkar). Future reviews should not flag this as missing functionality unless requirements change.

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts:212-220
Timestamp: 2025-08-08T10:26:13.362Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts should include the phone number in client-facing HttpError messages (e.g., in updatePhoneNumber/getPhoneNumber catch blocks). Do not suggest redacting the phone number from these errors unless requirements change (per maintainer: Udit-takkar).

Learnt from: Udit-takkar
PR: calcom/cal.com#21827
File: packages/lib/server/repository/phoneNumber.ts:153-160
Timestamp: 2025-08-05T13:17:23.491Z
Learning: In the Cal.com Cal AI phone feature, the deletePhoneNumber repository method validation is properly handled in the service layer (RetellAIService.deletePhoneNumber) which validates user ownership and authorization before calling the repository method. The repository layer correctly focuses on data access only.

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/interfaces/AIPhoneService.interface.ts:118-143
Timestamp: 2025-08-08T09:29:11.681Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/interfaces/AIPhoneService.interface.ts (TypeScript), the AIPhoneServiceAgentListItem is required to include user.email in listAgents responses (per maintainer Udit-takkar). Future reviews should not flag this as unnecessary PII unless requirements change.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/aiVoiceAgent/testCall.handler.ts:41-44
Timestamp: 2025-08-27T12:15:43.830Z
Learning: In calcom/cal.com, the AgentService.getAgent() method in packages/features/calAIPhone/providers/retellAI/services/AgentService.ts does NOT include authorization checks - it only validates the agentId parameter and directly calls the repository without verifying user/team access. This contrasts with other methods like getAgentWithDetails() which properly use findByIdWithUserAccessAndDetails() for authorization. When reviewing updateToolsFromAgentId() calls, always verify both agent ownership and eventType ownership are checked.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/aiVoiceAgent/_router.ts:117-126
Timestamp: 2025-08-17T22:00:16.329Z
Learning: In calcom/cal.com PR #22995, packages/trpc/server/routers/viewer/aiVoiceAgent/_router.ts, the enabled input parameter in the update endpoint is intentionally not forwarded to aiService.updateAgentConfiguration() as the enabled/disabled agent functionality is not required at the moment (per maintainer Udit-takkar). Future reviews should not flag this as missing functionality unless requirements change.

packages/features/shell/navigation/Navigation.tsx (1)

125-130: Localization key looks correct; resolves prior feedback

Using the "call_history" i18n key is consistent with the rest of the menu and addresses the earlier comment.

packages/features/shell/navigation/Navigation.tsx (1)

125-130: Optional: surface a phone icon for consistency with other entries

Uncommenting the icon improves visual scan and aligns with other nav items.

       {
         name: "call_history",
         href: "/insights/call-history",
-        // icon: "phone",
+        icon: "phone",
         isCurrent: ({ pathname: path }) => path?.startsWith("/insights/call-history") ?? false,
       },

packages/features/calAIPhone/providers/retellAI/RetellAIService.ts (1)

245-256: Add explicit Retell types to listCalls; skip local page-cap (CallService already defaults)

RetellCallListParams/RetellCallListResponse are exported from ./types — import and update the method signature. CallService already applies limit = 50, so no additional capping in RetellAIService is necessary. TRPC checks returned no credential.key or Prisma include leaks.

-  async listCalls(params: {
-    limit?: number;
-    offset?: number;
-    filters?: {
-      fromNumber: string[];
-      toNumber?: string[];
-      startTimestamp?: { lower_threshold?: number; upper_threshold?: number };
-    };
-  }) {
-    return this.callService.listCalls(params);
-  }
+  async listCalls(params: RetellCallListParams): Promise<RetellCallListResponse> {
+    return this.callService.listCalls(params);
+  }

Add import near existing ./types imports:

import type { RetellCallListParams, RetellCallListResponse } from "./types";

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/interfaces/AIPhoneService.interface.ts:118-143
Timestamp: 2025-08-08T09:29:11.681Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/interfaces/AIPhoneService.interface.ts (TypeScript), the AIPhoneServiceAgentListItem is required to include user.email in listAgents responses (per maintainer Udit-takkar). Future reviews should not flag this as unnecessary PII unless requirements change.

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts:212-220
Timestamp: 2025-08-08T10:26:13.362Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts should include the phone number in client-facing HttpError messages (e.g., in updatePhoneNumber/getPhoneNumber catch blocks). Do not suggest redacting the phone number from these errors unless requirements change (per maintainer: Udit-takkar).

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/AgentService.ts:195-216
Timestamp: 2025-08-08T09:27:23.896Z
Learning: In PR calcom/cal.com#22919, file packages/features/calAIPhone/providers/retellAI/services/AgentService.ts, the updateAgentConfiguration method intentionally does not persist the optional `name` parameter to the repository for now, per maintainer (Udit-takkar). Future reviews should not flag this unless requirements change.

packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.handler.ts (2)

31-37: Guard org-scoped filters when organizationId is undefined

Prevent teams with parentId === undefined from slipping in when there’s no org context.

-    const adminTeamIds = userMemberships
-      .filter((m) => m.team?.parentId === organizationId)
-      .map((m) => m.teamId);
+    const adminTeamIds = organizationId
+      ? userMemberships
+          .filter((m) => m.team?.parentId === organizationId)
+          .map((m) => m.teamId)
+      : [];
 
-    const isOrgOwner = userMemberships.some(
-      (m) => m.role === MembershipRole.OWNER && m.team?.parentId === organizationId
-    );
+    const isOrgOwner =
+      !!organizationId &&
+      userMemberships.some(
+        (m) => m.role === MembershipRole.OWNER && m.team?.parentId === organizationId
+      );

---

83-91: Fix truthiness check; handle epoch 0 correctly

Using truthiness skips validation when a bound is exactly 0. Compare against undefined.

-      if (
-        startTimestamp.lower_threshold &&
-        startTimestamp.upper_threshold &&
-        startTimestamp.lower_threshold > startTimestamp.upper_threshold
-      ) {
+      if (
+        startTimestamp.lower_threshold !== undefined &&
+        startTimestamp.upper_threshold !== undefined &&
+        startTimestamp.lower_threshold > startTimestamp.upper_threshold
+      ) {
         throw new TRPCError({
           code: "BAD_REQUEST",
           message: "startDate must be before or equal to endDate",
         });
       }

packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.handler.ts (2)

61-81: Prefer Number.isNaN over global isFinite for Date.parse validation

Date.parse returns a number or NaN; Number.isNaN is the precise check and avoids global-coercion semantics.

-        if (!isFinite(parsedStartDate)) {
+        if (Number.isNaN(parsedStartDate)) {
           throw new TRPCError({
             code: "BAD_REQUEST",
             message: "Invalid startDate format",
           });
         }
...
-        if (!isFinite(parsedEndDate)) {
+        if (Number.isNaN(parsedEndDate)) {
           throw new TRPCError({
             code: "BAD_REQUEST",
             message: "Invalid endDate format",
           });
         }

---

104-107: Sanitize outbound payload; never return secrets

Before returning, ensure the payload cannot contain credential.key or similar secret fields from downstream providers. Prefer an allowlist projection of fields needed by the UI.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/ai/_router.ts:46-84
Timestamp: 2025-08-14T10:48:52.586Z
Learning: In calcom/cal.com PR #22995, packages/trpc/server/routers/viewer/ai/_router.ts, the voiceId input parameter in the create endpoint is intentionally not forwarded to aiService.createAgent() as voice customization is not required at the moment (per maintainer Udit-takkar). Future reviews should not flag this as missing functionality unless requirements change.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/aiVoiceAgent/_router.ts:117-126
Timestamp: 2025-08-17T22:00:16.329Z
Learning: In calcom/cal.com PR #22995, packages/trpc/server/routers/viewer/aiVoiceAgent/_router.ts, the enabled input parameter in the update endpoint is intentionally not forwarded to aiService.updateAgentConfiguration() as the enabled/disabled agent functionality is not required at the moment (per maintainer Udit-takkar). Future reviews should not flag this as missing functionality unless requirements change.

packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.handler.ts (4)

20-20: Fix unsafe access to profiles array.

ctx.user.profiles[0] can throw when profiles is undefined. Use optional chaining on the index.

-  const organizationId = ctx.user.organizationId ?? ctx.user.profiles[0]?.organizationId;
+  const organizationId = ctx.user.organizationId ?? ctx.user.profiles?.[0]?.organizationId;

---

31-33: Guard org-scoped adminTeamIds when organizationId is undefined.

Current logic includes all admin team IDs when no org context, potentially widening phone-number access beyond the intended org. Short-circuit to an empty array when organizationId is falsy.

-    const adminTeamIds = userMemberships
-      .filter((m) => !organizationId || m.team?.parentId === organizationId)
-      .map((m) => m.teamId);
+    const adminTeamIds = organizationId
+      ? userMemberships
+          .filter((m) => m.team?.parentId === organizationId)
+          .map((m) => m.teamId)
+      : [];

---

107-113: Preserve TRPCError status; don’t mask BAD_REQUEST with 500.

Re-throw known TRPCError and only wrap unknowns.

-  } catch (error) {
-    logger.error(`Failed to list calls for user ${ctx.user.id}:`, error);
-    throw new TRPCError({
-      code: "INTERNAL_SERVER_ERROR",
-      message: "Failed to retrieve call history",
-    });
-  }
+  } catch (error) {
+    if (error instanceof TRPCError) {
+      throw error;
+    }
+    logger.error(`Failed to list calls for user ${ctx.user.id}:`, error);
+    throw new TRPCError({
+      code: "INTERNAL_SERVER_ERROR",
+      message: "Failed to retrieve call history",
+    });
+  }

---

82-91: Fix truthiness check for date bounds.

Using truthiness skips the comparison when a timestamp is 0 (Unix epoch). Compare against undefined explicitly.

-      if (
-        startTimestamp.lower_threshold &&
-        startTimestamp.upper_threshold &&
-        startTimestamp.lower_threshold > startTimestamp.upper_threshold
-      ) {
+      if (
+        startTimestamp.lower_threshold !== undefined &&
+        startTimestamp.upper_threshold !== undefined &&
+        startTimestamp.lower_threshold > startTimestamp.upper_threshold
+      ) {

packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.handler.ts (3)

54-54: Consider reusing/injecting the AI service provider.

If creation is non-trivial, initialize once at module scope or inject for easier testing and lower overhead.

---

103-106: totalCount should reflect the full result set if available.

If the provider returns a server-side total, surface it; otherwise document that totalCount equals the current page length.

---

95-96: Schema already enforces limit/offset; no handler clamp required.

ZListCallsInputSchema (packages/trpc/server/routers/viewer/aiVoiceAgent/listCalls.schema.ts) defines limit: z.number().min(1).max(1000).default(50) and offset: z.number().min(0).default(0), so input.limit/input.offset are validated. Optional: add .int() and/or reduce max to 100 to tighten page-size caps.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/ai/_router.ts:46-84
Timestamp: 2025-08-14T10:48:52.586Z
Learning: In calcom/cal.com PR #22995, packages/trpc/server/routers/viewer/ai/_router.ts, the voiceId input parameter in the create endpoint is intentionally not forwarded to aiService.createAgent() as voice customization is not required at the moment (per maintainer Udit-takkar). Future reviews should not flag this as missing functionality unless requirements change.

Learnt from: Udit-takkar
PR: calcom/cal.com#22995
File: packages/trpc/server/routers/viewer/aiVoiceAgent/_router.ts:117-126
Timestamp: 2025-08-17T22:00:16.329Z
Learning: In calcom/cal.com PR #22995, packages/trpc/server/routers/viewer/aiVoiceAgent/_router.ts, the enabled input parameter in the update endpoint is intentionally not forwarded to aiService.updateAgentConfiguration() as the enabled/disabled agent functionality is not required at the moment (per maintainer Udit-takkar). Future reviews should not flag this as missing functionality unless requirements change.

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts:212-220
Timestamp: 2025-08-08T10:26:13.362Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts should include the phone number in client-facing HttpError messages (e.g., in updatePhoneNumber/getPhoneNumber catch blocks). Do not suggest redacting the phone number from these errors unless requirements change (per maintainer: Udit-takkar).